Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix resource check logic #3238

Merged
merged 4 commits into from
Dec 11, 2023

Conversation

AllenShen
Copy link
Contributor

@AllenShen AllenShen commented Dec 11, 2023

What this PR does / Why we need it:

🤖[deprecated] Generated by Copilot at 0c2168c

Added support for external environment sources in Zadig by modifying the CheckResourceAppliedByOtherEnv function and adding a String method to the Workload struct. This allows Zadig to detect and display the environment data of resources that are managed by Helm or Kustomize.

What is changed and how it works?

🤖[deprecated] Generated by Copilot at 0c2168c

  • Add String method to Workload struct to format workload type and name (link, link)
  • Modify CheckResourceAppliedByOtherEnv function to handle external environment sources (link)

Does this PR introduce a user-facing change?

  • API change
  • database schema change
  • upgrade assistant change
  • change in non-functional attributes such as efficiency or availability
  • fix of a previous issue

Signed-off-by: allenshen <shendongdong@koderover.com>
Signed-off-by: allenshen <shendongdong@koderover.com>
Signed-off-by: allenshen <shendongdong@koderover.com>
Signed-off-by: allenshen <shendongdong@koderover.com>
@AllenShen AllenShen merged commit b3adba4 into koderover:main Dec 11, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants