game.controller.keyboard: Rename some keys and improve Readme #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This renames the following keys: * Left Super -> Left Windows * Right Super -> Right Windows * Mode -> Mode/Option/AltGr
garbear
force-pushed
the
keyboard-readme
branch
from
a1a4a95
to
deb4b62
Compare
Note, this also corrected "return" -> "enter", and fixed "{" and "}".
garbear
force-pushed
the
keyboard-readme
branch
from
deb4b62
to
d0265ec
Compare
|
Confirmed with run-time testing (see screenshots above) |
|
I'm not really happy with the Mode/Option/AltGr label. I've never seen AltGr on a physical keyboard. Also lengthy translations like German certainly can't fit all three words. So I'm renaming to "Mode/Option". |
8 tasks
This was referenced Feb 3, 2024
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While working on keyboard support in the Player Manager, I went through our keyboard layout with a fine-toothed comb. I found some improvements, and then improved the documentation as well.
How has this been tested?
Tested on v21 Beta 2. Buttons are successfully renamed: