Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Nexus] Update controller add-ons for new keyboard layout and translations #24636

Merged
merged 3 commits into from Feb 8, 2024

Conversation

garbear
Copy link
Member

@garbear garbear commented Feb 3, 2024

Description

This PR updates the controller add-ons, alongside the corresponding Omega PR (#24635).

Corresponding repo-resources PR is: xbmc/repo-resources#463. I think a good time to merge that will be when 20.4 hits 100% deployment on the Google Play store.

Changes are:

game.controller default

  • Added South Africa translations

game.controller.keyboard

game.controller.snes

  • Added South Africa translations

Motivation and context

Now that 20.4 is coming out imminently, let's update the controller add-ons, so that I can later sync them to repo-resources and we won't send out millions of add-on updates immediately on first install.

How has this been tested?

Testing in progress.

What is the effect on users?

  • Updated controller add-on translations

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • Student submission (PR was done for educational purposes and will be treated as such)
  • None of the above (please explain below)

@garbear
Copy link
Member Author

garbear commented Feb 3, 2024

Hold off on merging, testing kodi-game/controller-topology-project#290 uncovered a bug, fixed in #24639

@garbear garbear changed the title [Nexus] Update controller add-ons for new translations [Nexus] Update controller add-ons for new keyboard layout and translations Feb 5, 2024
@garbear
Copy link
Member Author

garbear commented Feb 8, 2024

#24639 merged, this is ready to go.

@garbear garbear merged commit ae637e6 into xbmc:Nexus Feb 8, 2024
1 check passed
@garbear garbear deleted the nexus-controllers branch February 8, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant