fix api version and avoid unclean kodi exit #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jalle19
reviewed
Sep 23, 2016
| // if (retval < 0) | ||
| // { | ||
| // XBMC->Log(LOG_NOTICE, "CEventsThread:: unsubscribe from events failed"); | ||
| // } |
There was a problem hiding this comment.
I would just remove the code instead of uncommented it.
|
You can safely ignore the XCode 6.1 build error, it's unrelated. |
|
Removed the code, and just left the comment. |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets the PVR API version 5.2.0 which is missing in #53.
Also, when quitting Kodi, a network call to 'unsubscribe service events' causes an exception. Network services seem to be already unavailable when pvrmanger destroys the add-on. So, removing that call avoids it.
Either way the call will never succeed unless the user manually disables the add-on before quitting Kodi. And nobody wants to do that every time. Removing the call is user friendliest option for now I think, since AFAIK PVR add-ons can't get 'quit' announcements. Unless something changes in Kodi master.
osx stacktrace
kodi log