Fixed double free of htsp message #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…CTvheadend::UpdateTimer.
|
UpdateTimer creates m -> SendDvrUpdate(m) -> SendAndWait(m) frees m & returns new m that was not freed by SendDvrUpdate (but UpdateTimer double freed the one it ceated and had passed over to SendAndWait). Thus, this fixes not only a double free but also a memory leak. |
|
Nice find! |
ksooo
added a commit
that referenced
this pull request
Mar 17, 2015
Fixed double free of htsp message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed double free of htsp message in CTvheadend::RenameRecording and CTvheadend::UpdateTimer.
Program terminated with signal SIGSEGV, Segmentation fault.
#0 0x00000000008dd737 in htsmsg_field_destroy (f=0x3d8fc70, msg=) at htsmsg.c:42
....
Thread 1 (Thread 0x7f9b9029a780 (LWP 1663)):
#0 0x00000000008dd737 in htsmsg_field_destroy (f=0x3d8fc70, msg=) at htsmsg.c:42
#1 0x00000000008dd9e1 in htsmsg_clear (msg=) at htsmsg.c:76
#2 htsmsg_destroy (msg=0x39cf810) at htsmsg.c:180
#3 0x00007f9b8034a48f in CTvheadend::UpdateTimer (this=0x7f9b4800e070, timer=...) at /home/kai/src/openelec/OpenELEC.tv/build.OpenELEC-Generic.x86_64-devel/kodi-pvr-add
ons-b2dc035/addons/pvr.hts/src/Tvheadend.cpp:660
#4 0x0000000000c5bda1 in PVR::CPVRClient::UpdateTimer (this=0x7f9b48005b20, timer=...) at PVRClient.cpp:986
#5 0x0000000000c60cde in PVR::CPVRClients::UpdateTimer (this=, timer=...) at PVRClients.cpp:412
#6 0x0000000000a674fa in PVR::CPVRTimerInfoTag::UpdateOnClient (this=0x7f9b40118400) at PVRTimerInfoTag.cpp:399
#7 0x0000000000a6a0bf in PVR::CPVRTimers::UpdateTimer (item=...) at PVRTimers.cpp:613
...