Implement PVR API 5.0.0 #195
Conversation
|
The build errors are expected as ci builds against old API headers. |
| if (prevState != newState) | ||
| { | ||
| /* Notify connection state change (callback!) */ | ||
| PVR->ConnectionStateChange(GetServerString().c_str(), newState, NULL); |
There was a problem hiding this comment.
Couldn't this be done in the same if block as above?
There was a problem hiding this comment.
No, callback must not be called with mutex locked. #195 (diff)
There was a problem hiding this comment.
You're right, I missed the mutex part.
|
don't forget #169 |
|
@Jalle19 by any chance, I would like to get this PR merged before all the other refactoring PRs. The code is well-tested and I will have not much time during the next weeks for rebasing and retesting all this. What do you think? Ofc, I will address the other - non-refactoring related - points you raised before merging this PR. |
|
@ksooo fine by me |
|
@Jalle19 Thanks, Sam. |
Cool. My plan is to merge the Kodi API bump PR mid to end of Feb. |
|
@ksooo wasn't it agreed that every addon maintainer has to implement addon changes on their own instead of having one guy do a reference implementation for all? |
I think if the implementation is trivial (in the sense of not requiring real knowledge of addon internals) if somebody steps up and implements everything (as I did here) all is fine. However, what we must avoid is providing implementations if we are not really know what we are doing - happened more than one time in the past with implementation of new functions - for instance with IsTimeshifting. That's why I refrained from implementing API 4.2.0 for pvr.dvlink and pvr.dvbviewer. These addons support timeshifting and I have no clue how to implement IsRealTimeStream for those. |
|
@ksooo fair point. I have nothing against "outsiders" keeping addons working, just wanted to check if I missed something in the previous discussion. |
Implementation of PVR Addon API 5.0.0 as defined here xbmc/xbmc#8736
Note: SetEPGTimeFrae currently is a stub only, to be implemented later. Other stuff is fully implemented and runtime-tested for some weeks now.
@Jalle19 Your opinion?