Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse, store and log descrambler info #169

Closed
wants to merge 3 commits into from

Conversation

Jalle19
Copy link
Contributor

@Jalle19 Jalle19 commented Jan 11, 2016

Partially closes #106. The API will need some changes in order to make this information useful (for now it's just stored, not passed along to Kodi in any way).

@ksooo
Copy link
Member

ksooo commented Jan 11, 2016

The API will need some changes in order to make this information useful

I will be happy to include this change in our PVR Addon API 5.0.0 PR if you point me to a proper commit that I can cherry-pick. ;-)

@Jalle19
Copy link
Contributor Author

Jalle19 commented Jan 12, 2016

Scribbling some stuff here for future reference:

Addons will need a way to publish descrambler information to Kodi. Kodi should then store this information in CPVRGUInfo where the skin can grab it. Kodi should clear the stored information when changing channels or when stopping playback to prevent stale information from being displayed.

Since most existing API methods are "pull" methods (i.e. Kodi pulls the information from the addon) this one should probably follow that convention. This way Kodi can also control whether to fetch the information at all.

The method signature could be something like this: PVR_ERROR GetDescramblerInfo(PVR_DESCRAMBLER_INFO *info) where PVR_DESCRAMBLER_INFO is a struct. This struct could probably be quite close to the descrambleInfo message tvheadend sends to clients since that contains pretty much every piece of information a descrambler could possibly provide. This method would be called during playback at certain intervals.

While we're at it I'd like to also implement an API method for retrieving e.g. how many tuners the server has, which tuners are used at the moment, what is the delivery system used for the current channel (DVB-T/C/S etc.) and so on. There are some skins (notable Aeon Nox master) that technically support all this data, there's just no way to get them at the moment.

@ksooo
Copy link
Member

ksooo commented Jan 12, 2016

While we're at it I'd like to also implement an API method for retrieving e.g. how many tuners the server has, which tuners are used at the moment, what is the delivery system used for the current channel (DVB-T/C/S etc.) and so on.

Nice

@Jalle19
Copy link
Contributor Author

Jalle19 commented Jan 12, 2016

I actually started work on the latter suggestion in a branch, I'll try to revive it at some point. How much in a hurry are you to get the 5.0.0 API bump in?

@ksooo
Copy link
Member

ksooo commented Jan 12, 2016

No hurry at all. Just collecting stuff atm. Want to avoid multiple API bumps for Krypton, if possible.

@L-S-D L-S-D mentioned this pull request Feb 7, 2016
@ksooo
Copy link
Member

ksooo commented Aug 2, 2017

This one can be closed, I cherry-picked the main commit for #315

@ksooo ksooo closed this Aug 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants