Implement PVR Addon API changes for Leia #315
Conversation
|
BTW, this fixes #106 |
|
Big thx for implementing this. |
|
thx for last commit, any chance get information how many min left to end of program ?
that i got over tvheadend api but should be in htsp delivery - i think that basic information. |
|
@piotrasd if you don't stop to spam here with unrelated stuff I will ban you. Use the forum or open an issue here for feature requests. BTW, this is not a pvr.hts issue. Ask the skinners in the Kodi forum for support, please. |
src/HTSPDemuxer.cpp
Outdated
| { | ||
| CLockObject lock(m_mutex); | ||
|
|
||
| info = {0}; |
There was a problem hiding this comment.
In pvr.hts, we everywhere zero the structs that are passed to the addon from outside, yes. Usually we use memset, but I prefer modern syntax nowadays. btw, memset would overwrite the vtable of the struct if it would have one.
There was a problem hiding this comment.
Ah, and main reason is, if a member gets added to a struct by an api change, this prevents that the initialization of the new member must be explicitly added to every addon. As long as the new member's default value is "0" (in memory represantation), this is very handy.
ksooo
force-pushed
the
pvr-api-leia
branch
3 times, most recently
from
8991f14
to
94df0d1
Compare
pvr.hts/addon.xml.in
Outdated
| @@ -1,7 +1,7 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| <addon | |||
| id="pvr.hts" | |||
| version="4.0.16" | |||
| version="4.0.17" | |||
There was a problem hiding this comment.
Maybe we should use 4.1.0 instead since this implements a new verison the PVR API?
ksooo
force-pushed
the
pvr-api-leia
branch
5 times, most recently
from
2d797de
to
0b1a3fb
Compare
…VR_ADDON_CAPABILITIES lifetime values
Refer to xbmc/xbmc#12303 for more details.
@Jalle19 this is WIP, review welcome, but WIP wrt other changes that might follow. BTW, I took myself the freedom to cherry-pick from https://github.com/Jalle19/pvr.hts/tree/htsp-descramble-info ;-)