Add support for all product families ("VB", "VJ", "VZ" etc) #112
Conversation
Hi, I'm an R&D software engineer for VBox Comm - that's the company that owns the product that this add-on integrates into Kodi.
SO far the only product family was "VB", which is the reason it's been hard-coded in this function.
Now we have a line of a new product that's being tested right now ("VJ"), and we need the add-on to recognize those devices as well. Other future products will also be in that format ("V"+another capital letter).
Thanks a lot,
Ariel
|
Looks good, don't mind the Travis failures for now. Are you able to do some maintenance on this addon? I'm the original coder but I don't have enough time or interest at the moment to keep up with development, and there's always the risk that addons that don't build or work properly for some time get dropped from the official repository. |
Add support for all product families ("VB", "VJ", "VZ" etc)
|
Hi Sam, As you know by now (and as I wrote in the original code suggestion), I'm a member of the VBox Comm R&D team. My name is Ariel, by the way. First of all, the addon (in my opinion) - very well done. Second - we will take control of the code, since we know how important Kodi users (and addons) are. Actually, we went into GitHub just for that. So to help us do that, I have a question for you: What exactly does is require for our addon to be in the nightly build of Kodi? Because currently, after installing the nightly build, it seems our addon isn't included. And what does this mean for the next Kodi release? How do we make sure our addon is included in it? Thanks, Ariel From: Sam Stenvall [mailto:notifications@github.com] Looks good, don't mind the Travis failures for now. Are you able to do some maintenance on this addon? I'm the original coder but I don't have enough time or interest at the moment to keep up with development, and there's always the risk that addons that don't build or work properly for some time get dropped from the official repository. — |
|
Hi @relipo it currently fails to build on windows only. Once that is solved it should be included automaticly |
Thank you, I really tried to do my best since this was commissioned work.
I suspect the Windows build failure (and the Travis failures on OS X) is due to an API change that hasn't been implemented in the addon yet. The PVR API (which is the API between Kodi and PVR addons) was bumped to 4.2.0 while the addon currently implements 4.1.0. The missing change is implementing the changes done in xbmc/xbmc#8896. For this addon I think it's enough to return |
|
@relipo I added you as a collaborator so you can push to this repository, but I'd prefer if you create PRs instead of pushing to master directly. This way Travis gets a chance to catch build errors and I get a chance to do a review. I hope that's okay. |
|
O.K, so just making sure: I have the patch so the VBox Gateway addon works with the 4.2.0 PVR API.
· If it was bumped for v16.0, I need it to be in the v16.0. Possible? · If it was bumped for v17.0 - will my VB / VJ / VZ patch be in v16.0 (works regardless of the PVR API)?
I'm considering adding some more changes, so just a quick question: how long do you think before that version closes as well? Thanks again, Ariel From: Sam Stenvall [mailto:notifications@github.com] Thank you, I really tried to do my best since this was commissioned work. I suspect the Windows build failure (and the Travis failures on OS X) is due to an API change that hasn't been implemented in the addon yet. The PVR API (which is the API between Kodi and PVR addons) was bumped to 4.2.0 while the addon currently implements 4.1.0. The missing change is implementing the changes done in xbmc/xbmc#8896 xbmc/xbmc#8896 . For this addon I think it's enough to return true when playing live TV and false when playing recordings. — |
|
The API was only bumped in Kodi master so there's no need to change anything in that regard for Jarvis. |
|
@relipo to be clear you would need to made anew PR against jarvis branch with this patch (including a minor version bump and changelog) if you also want this in the Kodi v16 release |
|
O.K, great. I'll just ask this: I know the nightly builds refer to the development of v17.0, but is there a way for me to make sure my fix is a part of the v16.0 release? (except building that branch from source, which I already did & seems fine) Thanks again, Ariel |
|
We're going to bump all addons to the latest revision from the Jarvis branches soon (or it could be done already, I haven't checked). @MartijnKaiser knows the details of how it's done better than me. |
|
We just point to Jarvis branch for PVR while for all other we point to specific git SHA. So all stuff added to jarvis will be auto included in whatever is latest build |
|
Very nice, thanks for clearing that up. |
Hi, I'm an R&D software engineer for VBox Comm - that's the company that owns the product that this add-on integrates into Kodi.
SO far the only product family was "VB", which is the reason it's been hard-coded in this function.
Now we have a line of a new product that's being tested right now ("VJ"), and we need the add-on to recognize those devices as well. Other future products will also be in that format ("V"+another capital letter).
Thanks a lot,
Ariel