-
Notifications
You must be signed in to change notification settings - Fork 28
Commit
- Loading branch information
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
<?xml version="1.0" encoding="UTF-8"?> | ||
<addon | ||
id="pvr.vdr.vnsi" | ||
version="2.6.9" | ||
version="3.0.0" | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
ksooo
Author
Member
|
||
name="VDR VNSI Client" | ||
provider-name="FernetMenta, Team Kodi"> | ||
<requires> | ||
|
8 comments
on commit 4d17aaf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah sh.., sorry, part of another part with complete reworked system.
I can create a change if acceptable now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ups, thought was changed from me, has used several values to check the version compare on Kodi.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@FernetMenta the reason it makes sense to bump the major version is so that there is less confusing regarding backported version bumps. Now you may end up with situations where 2.7.1 is for Krypton but 2.7.2 is for Jarvis etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Plus an addon for Kodi v18 most definitely won't work for Kodi v17, so a major version bump seems entirely appropriate to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as already mentioned: my addon, my decision
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the "won't work" is not exactly true. The add-ons have a C
Interface with function table and currently own C
headers, as long this is not changed can be e.g. a screensaver from v12 also used on v17.
Due to the bigger changes on e.g. PVR, was it OK, but not the right. As long a add-on header is not changed is also not needed to change add-on version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As long a add-on header is not changed is also not needed to change add-on version.
Again, don't mix API version and addon version, please. API is for technical changes, to ensure compatibility. Addon version is (also) for functional changes. If I add a new feature to an addon, without changing the Kodi addon API, I will ofc, not bump the API version, but I will bump the addon version (for instance to announce to users, "hey new addon version x.y.z supports PVR backend feature foo". Seems, we are not talking the same language?!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ksooo you're right. Was for my so clear with a change on code that I not written it :)
what is that? does not comply with my version schema :(