Skip to content
This repository has been archived by the owner on Dec 31, 2020. It is now read-only.

Strict Mode #20

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Strict Mode #20

wants to merge 14 commits into from

Conversation

MartinLoeper
Copy link

@MartinLoeper MartinLoeper commented Feb 12, 2018

As explained in #18, several variable declarations are missing.
The strict mode behaviour is defined here: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Strict_mode.

Any assignment that silently fails in normal code (assignment to a non-writable global or property, assignment to a getter-only property, assignment to a new property on a non-extensible object) will throw in strict mode [...]

I also included #17 by @arkraft.
The changes provided are running in our environment without issues.

closes #18

@MartinLoeper
Copy link
Author

Do not forget to squash the commits during merge. Unfortunately, I did not have time to do this today.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NodeJs: Regions is not defined (in strict_mode)
2 participants