This repository has been archived by the owner on Aug 15, 2022. It is now read-only.
Show is canceling step in Subscription cancel modal #10831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Umut Sirin <umutsirin1@gmail.com>
Signed-off-by: Umut Sirin <umutsirin1@gmail.com>
Signed-off-by: Umut Sirin <umutsirin1@gmail.com>
Signed-off-by: Umut Sirin <umutsirin1@gmail.com>
Signed-off-by: Umut Sirin <umutsirin1@gmail.com>
gokmen
approved these changes
Mar 22, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides a better ux by showing canceling state via changing the title of confirm button on
CancelSubscriptionModalDescription
Previously we were not showing any feedback to user, by simply closing the modal and not showing any info, and reloading the window while there seems to be nothing running on the screen. This PR aims to resolve this issue by not closing the modal while making the cancel request, and let it reload as before once it's successful. We basically don't allow user to do anything before cancel request is ended. If there is an error the button will return to the default state.