New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Design @1x #228
Design @1x #228
Conversation
...I will write/update tests too if you are cool with this @koenbok ;) |
I just realized that my changes to @koenbok what do you think about this? |
Ooh this looks pretty interesting. I'll try and take a closer look tomorrow! |
Also, don't actually scale `DeviceComponent#content`, but rather scale `DeviceComponent#viewport`
This reverts commit 3424b06.
Animating `contentScale` via `setContentScale` works again and the viewport scale is now correctly set when viewing on device.
Also, make `_setViewportScale` `_update` by default.
Any news? |
Hey @peteschaffner we're still pretty interested in solving this. Are you still thinking about finishing approach? If so feel free to re-open. |
Designing @1x is super important to me, and the more I use FS as a design tool, it becomes even more imperative (this means less ⌘I and more direct drawing in Framer). It is also extremely beneficial for cleaner communication between designers and engineers (app.coffee becomes a source of self-documenting design ... no more red-lines).
Here is a test project (with an augmented template Sketch file included) where you can see the changes in action.
Related: https://www.facebook.com/groups/framerjs/permalink/641286459331762/