Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design @1x #228

Closed
wants to merge 7 commits into from
Closed

Design @1x #228

wants to merge 7 commits into from

Conversation

peteschaffner
Copy link
Contributor

Designing @1x is super important to me, and the more I use FS as a design tool, it becomes even more imperative (this means less ⌘I and more direct drawing in Framer). It is also extremely beneficial for cleaner communication between designers and engineers (app.coffee becomes a source of self-documenting design ... no more red-lines).

Here is a test project (with an augmented template Sketch file included) where you can see the changes in action.

Related: https://www.facebook.com/groups/framerjs/permalink/641286459331762/

@peteschaffner
Copy link
Contributor Author

...I will write/update tests too if you are cool with this @koenbok ;)

@peteschaffner
Copy link
Contributor Author

I just realized that my changes to index.html will break things when viewed on device for existing projects that are designed in absolute pixels. I reverted those changes and added some logic to update the viewport meta tag when setting DeviceComponent#contentScale. This should make things compatible with existing projects and shouldn't require any of the Studio demos/templates to be reworked.

@koenbok what do you think about this?

@koenbok
Copy link
Owner

koenbok commented Jul 15, 2015

Ooh this looks pretty interesting. I'll try and take a closer look tomorrow!

Pete Schaffner added 7 commits July 19, 2015 17:44
Also, don't actually scale `DeviceComponent#content`, but rather scale
`DeviceComponent#viewport`
Animating `contentScale` via `setContentScale` works again and the
viewport scale is now correctly set when viewing on device.
Also, make `_setViewportScale` `_update` by default.
@rssems
Copy link

rssems commented Aug 27, 2015

Any news?

@koenbok
Copy link
Owner

koenbok commented Dec 14, 2015

Hey @peteschaffner we're still pretty interested in solving this. Are you still thinking about finishing approach? If so feel free to re-open.

@koenbok koenbok closed this Dec 14, 2015
@peteschaffner peteschaffner mentioned this pull request Mar 4, 2016
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants