Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm back :)
@koenbok I simplified my approach from #228, but now need a little help from you to get this in an acceptable state to merge.
Must-haves
Framer.Device.contentScale
by drawing all imported layers at the appropriate size (divided by the scale factor)I'm a bit confused with the existing behavior because if I import a design drawn at 1x using the new importer scaling feature, all my layer dimensions are scaled by that factor, yet the
layerFrame
andimage.frame
values in the generated JSON are relative (at 1x) values.Nice-to-haves
index.html
andDeviceComponent.coffee
)DeviceComponent#relativeUnits
and then do the extra legwork to add the appropriatecontentScale
properties to the built-in device configurations