Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed multiple devices clashing with add/remove #46

Merged
merged 1 commit into from
Mar 10, 2024

Conversation

P-Storm
Copy link
Contributor

@P-Storm P-Storm commented Mar 10, 2024

Looks like fixing #31 and #36 .

Note: The brightness PR should be also be changed to reflect this approach.

The problem was that we defined a 'global' collection, and every time we tried to add those in, it would add 'all' in the global, not only the new ones.

@koenhendriks
Copy link
Owner

Thanks for your contribution, this PR looks good to me and I'm willing to just merge it without feature testing it myself :) I'll tag a new release ASAP after the merge.

@koenhendriks koenhendriks merged commit 5cfb61a into koenhendriks:main Mar 10, 2024
1 of 2 checks passed
@P-Storm P-Storm deleted the fix/multiple_devices branch March 10, 2024 20:55
@nvdweem
Copy link

nvdweem commented Mar 11, 2024

This does not seem to fix #36.

I removed my devices, updated to 0.0.9 and re-added them:

image
All devices have the display + 2 bars. No idea why 2 Btn+ devices show 3 devices and the other shows 4.

The controls are still grouped:
image

@P-Storm
Copy link
Contributor Author

P-Storm commented Mar 11, 2024

This does not seem to fix #36.

I removed my devices, updated to 0.0.9 and re-added them:

image All devices have the display + 2 bars. No idea why 2 Btn+ devices show 3 devices and the other shows 4.

The controls are still grouped: image

Can you give me the config json of your 3 devices? http://ip:port/config

Note: It contains your broker credentials plain text, so maybe obscure that :)

Can you also screenshot all button+ devices in the device list?

@nvdweem
Copy link

nvdweem commented Mar 11, 2024

Requested files attached.

benchmark-config.json
woonkamer-config.json
slaapkamer-config.json
ha-all-devices

@wimjanse
Copy link
Contributor

Same problem. I have 2x B+ both with 3 bars.
I removed both B+'s from the integration and re-added both.
First B+ shows up completely, display and 3 bars
Second B+ shows up with the display and only 1 bar

@P-Storm P-Storm mentioned this pull request Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants