Two B+'s, cannot assign B+ to different areas

[wimjanse]

Describe the bug
I added first B+ with ID 45_a450 to HA, area: "Studeerkamer". Then added second B+ with ID 45_a5d0, during addition I see the Display and 3 BARS, already with area "Studeerkamer". When I make a change in area ("Huiskamer") during the addition of the second B+, also the first B+ changes to "Huiskamer"

To Reproduce
Steps to reproduce the behavior:

• Add device B+ nr.1 to Integration, give IP address of B+ no. 1 and thereafter enter area for Display, Bar 1/2/3.
• Add device B+ nr.2 to Integration, give IP address of B+ no. 2, areas for Display and Bar 1/2/3 now show area from no.1
• During this addition, change are for no.2
• Also area for no.1 is changed to same as given above for no.2

Expected behavior
Different areas for the two B+'s

[nvdweem]

I might be having the same issue, but my devices aren't entirely grouped together.

I can set labels for the (3 in my case) devices but I had to rename them all to be sure which one is which as they all show up in the same place. The Integration page does correctly show the separate devices, but choosing 1 device shows all same-bars combined in 1 device.

Here you see the 3 devices grouped together. The devices have their names changed, that made them group up nicely. Before that it was all a mess.

These haven't gotten a new name, it's completely unclear which label changes what.

[koenhendriks]

This seems like an error in how the ButtonPlusHub class is currently setup. There is only 1 instance but it is carrying logic for multiple devices. I need to look into changing this and maybe create a sub device for the base module to split each physical device on (button bars and display).

It's a bit hard to test this as I've only a single ButtonPlus to develop with.

[koenhendriks]

I've added the hub id as a prefix for the child devices' identifiers in 0.0.8 this might potential fix this issue. Please remove the integration and entities manually before upgrading and after the upgrade please try again @wimjanse @nvdweem

[nvdweem]

I removed the entities and updated the integration, issue was not fixed.

[wimjanse]

Issue not fixed

Same here, manually removed both entities, updated and reinstalled.
After B+ nr 1, I assigned area "Studeerkamer" to Display and Bars 1, 2 and 3.
Thereafter, added B+ nr 2, I assigned area "Huiskamer" to Display and Bars 1, 2 and 3. Area's of B+ nr 1 are now also indicated as "Huiskamer", so cannot distinguish between both B+'s.

[koenhendriks]

Hey guys, Sorry for the late response I was on holiday. I will reopen this issue.

I will soon receive a second Button+ device so then I'll be able to better debug this issue and hopefully come up with a solution soon.

[wimjanse]

Hi Koen, some additional info: I see the displays and the bars of the two B+'s as one device (i.e. one device for the displays, one device for Bar-1, id for Bar-2 and id for Bar-3). Within the device, I can distinguish between the two B+'s based on entities, so for instance within the Bar-1 (device) I have entities for buttons of Bar-1 of B+ nr.1 and for the buttons of Bar-1 of B+ nr.2 . Hope this helps, Rgds, Wim

…

On 12 Feb 2024, at 19:34, Koen Hendriks ***@***.***> wrote: Hey guys, Sorry for the late response I was on holiday. I will reopen this issue. I will soon receive a second Button+ device so then I'll be able to better debug this issue and hopefully come up with a solution soon. — Reply to this email directly, view it on GitHub <#36 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AEZYD5DMEIAKBBBREKB74MTYTJODHAVCNFSM6AAAAABB3G6ZMGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZZGMYTEMRSGA>. You are receiving this because you were mentioned.