Skip to content

Commit

Permalink
Merge branch 'x86-fixes-for-linus' of git://git.kernel.org/pub/scm/li…
Browse files Browse the repository at this point in the history
…nux/kernel/git/tip/linux-2.6-tip

* 'x86-fixes-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip:
  x86: ce4100: Set pci ops via callback instead of module init
  x86/mm: Fix pgd_lock deadlock
  x86/mm: Handle mm_fault_error() in kernel space
  x86: Don't check for BIOS corruption in first 64K when there's no need to
  • Loading branch information
torvalds committed Mar 14, 2011
2 parents 52d3c03 + 0315017 commit 869c34f
Show file tree
Hide file tree
Showing 9 changed files with 45 additions and 37 deletions.
6 changes: 6 additions & 0 deletions arch/x86/include/asm/ce4100.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
#ifndef _ASM_CE4100_H_
#define _ASM_CE4100_H_

int ce4100_pci_init(void);

#endif
8 changes: 4 additions & 4 deletions arch/x86/kernel/check.c
Original file line number Diff line number Diff line change
Expand Up @@ -106,8 +106,8 @@ void __init setup_bios_corruption_check(void)
addr += size;
}

printk(KERN_INFO "Scanning %d areas for low memory corruption\n",
num_scan_areas);
if (num_scan_areas)
printk(KERN_INFO "Scanning %d areas for low memory corruption\n", num_scan_areas);
}


Expand Down Expand Up @@ -143,12 +143,12 @@ static void check_corruption(struct work_struct *dummy)
{
check_for_bios_corruption();
schedule_delayed_work(&bios_check_work,
round_jiffies_relative(corruption_check_period*HZ));
round_jiffies_relative(corruption_check_period*HZ));
}

static int start_periodic_check_for_corruption(void)
{
if (!memory_corruption_check || corruption_check_period == 0)
if (!num_scan_areas || !memory_corruption_check || corruption_check_period == 0)
return 0;

printk(KERN_INFO "Scanning for low memory corruption every %d seconds\n",
Expand Down
14 changes: 10 additions & 4 deletions arch/x86/mm/fault.c
Original file line number Diff line number Diff line change
Expand Up @@ -229,15 +229,14 @@ void vmalloc_sync_all(void)
for (address = VMALLOC_START & PMD_MASK;
address >= TASK_SIZE && address < FIXADDR_TOP;
address += PMD_SIZE) {

unsigned long flags;
struct page *page;

spin_lock_irqsave(&pgd_lock, flags);
spin_lock(&pgd_lock);
list_for_each_entry(page, &pgd_list, lru) {
spinlock_t *pgt_lock;
pmd_t *ret;

/* the pgt_lock only for Xen */
pgt_lock = &pgd_page_get_mm(page)->page_table_lock;

spin_lock(pgt_lock);
Expand All @@ -247,7 +246,7 @@ void vmalloc_sync_all(void)
if (!ret)
break;
}
spin_unlock_irqrestore(&pgd_lock, flags);
spin_unlock(&pgd_lock);
}
}

Expand Down Expand Up @@ -828,6 +827,13 @@ mm_fault_error(struct pt_regs *regs, unsigned long error_code,
unsigned long address, unsigned int fault)
{
if (fault & VM_FAULT_OOM) {
/* Kernel mode? Handle exceptions or die: */
if (!(error_code & PF_USER)) {
up_read(&current->mm->mmap_sem);
no_context(regs, error_code, address);
return;
}

out_of_memory(regs, error_code, address);
} else {
if (fault & (VM_FAULT_SIGBUS|VM_FAULT_HWPOISON|
Expand Down
6 changes: 3 additions & 3 deletions arch/x86/mm/init_64.c
Original file line number Diff line number Diff line change
Expand Up @@ -105,18 +105,18 @@ void sync_global_pgds(unsigned long start, unsigned long end)

for (address = start; address <= end; address += PGDIR_SIZE) {
const pgd_t *pgd_ref = pgd_offset_k(address);
unsigned long flags;
struct page *page;

if (pgd_none(*pgd_ref))
continue;

spin_lock_irqsave(&pgd_lock, flags);
spin_lock(&pgd_lock);
list_for_each_entry(page, &pgd_list, lru) {
pgd_t *pgd;
spinlock_t *pgt_lock;

pgd = (pgd_t *)page_address(page) + pgd_index(address);
/* the pgt_lock only for Xen */
pgt_lock = &pgd_page_get_mm(page)->page_table_lock;
spin_lock(pgt_lock);

Expand All @@ -128,7 +128,7 @@ void sync_global_pgds(unsigned long start, unsigned long end)

spin_unlock(pgt_lock);
}
spin_unlock_irqrestore(&pgd_lock, flags);
spin_unlock(&pgd_lock);
}
}

Expand Down
18 changes: 8 additions & 10 deletions arch/x86/mm/pageattr.c
Original file line number Diff line number Diff line change
Expand Up @@ -57,12 +57,10 @@ static unsigned long direct_pages_count[PG_LEVEL_NUM];

void update_page_count(int level, unsigned long pages)
{
unsigned long flags;

/* Protect against CPA */
spin_lock_irqsave(&pgd_lock, flags);
spin_lock(&pgd_lock);
direct_pages_count[level] += pages;
spin_unlock_irqrestore(&pgd_lock, flags);
spin_unlock(&pgd_lock);
}

static void split_page_count(int level)
Expand Down Expand Up @@ -394,7 +392,7 @@ static int
try_preserve_large_page(pte_t *kpte, unsigned long address,
struct cpa_data *cpa)
{
unsigned long nextpage_addr, numpages, pmask, psize, flags, addr, pfn;
unsigned long nextpage_addr, numpages, pmask, psize, addr, pfn;
pte_t new_pte, old_pte, *tmp;
pgprot_t old_prot, new_prot, req_prot;
int i, do_split = 1;
Expand All @@ -403,7 +401,7 @@ try_preserve_large_page(pte_t *kpte, unsigned long address,
if (cpa->force_split)
return 1;

spin_lock_irqsave(&pgd_lock, flags);
spin_lock(&pgd_lock);
/*
* Check for races, another CPU might have split this page
* up already:
Expand Down Expand Up @@ -498,14 +496,14 @@ try_preserve_large_page(pte_t *kpte, unsigned long address,
}

out_unlock:
spin_unlock_irqrestore(&pgd_lock, flags);
spin_unlock(&pgd_lock);

return do_split;
}

static int split_large_page(pte_t *kpte, unsigned long address)
{
unsigned long flags, pfn, pfninc = 1;
unsigned long pfn, pfninc = 1;
unsigned int i, level;
pte_t *pbase, *tmp;
pgprot_t ref_prot;
Expand All @@ -519,7 +517,7 @@ static int split_large_page(pte_t *kpte, unsigned long address)
if (!base)
return -ENOMEM;

spin_lock_irqsave(&pgd_lock, flags);
spin_lock(&pgd_lock);
/*
* Check for races, another CPU might have split this page
* up for us already:
Expand Down Expand Up @@ -591,7 +589,7 @@ static int split_large_page(pte_t *kpte, unsigned long address)
*/
if (base)
__free_page(base);
spin_unlock_irqrestore(&pgd_lock, flags);
spin_unlock(&pgd_lock);

return 0;
}
Expand Down
11 changes: 4 additions & 7 deletions arch/x86/mm/pgtable.c
Original file line number Diff line number Diff line change
Expand Up @@ -121,14 +121,12 @@ static void pgd_ctor(struct mm_struct *mm, pgd_t *pgd)

static void pgd_dtor(pgd_t *pgd)
{
unsigned long flags; /* can be called from interrupt context */

if (SHARED_KERNEL_PMD)
return;

spin_lock_irqsave(&pgd_lock, flags);
spin_lock(&pgd_lock);
pgd_list_del(pgd);
spin_unlock_irqrestore(&pgd_lock, flags);
spin_unlock(&pgd_lock);
}

/*
Expand Down Expand Up @@ -260,7 +258,6 @@ pgd_t *pgd_alloc(struct mm_struct *mm)
{
pgd_t *pgd;
pmd_t *pmds[PREALLOCATED_PMDS];
unsigned long flags;

pgd = (pgd_t *)__get_free_page(PGALLOC_GFP);

Expand All @@ -280,12 +277,12 @@ pgd_t *pgd_alloc(struct mm_struct *mm)
* respect to anything walking the pgd_list, so that they
* never see a partially populated pgd.
*/
spin_lock_irqsave(&pgd_lock, flags);
spin_lock(&pgd_lock);

pgd_ctor(mm, pgd);
pgd_prepopulate_pmd(mm, pgd, pmds);

spin_unlock_irqrestore(&pgd_lock, flags);
spin_unlock(&pgd_lock);

return pgd;

Expand Down
7 changes: 4 additions & 3 deletions arch/x86/pci/ce4100.c
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@
#include <linux/pci.h>
#include <linux/init.h>

#include <asm/ce4100.h>
#include <asm/pci_x86.h>

struct sim_reg {
Expand Down Expand Up @@ -306,10 +307,10 @@ struct pci_raw_ops ce4100_pci_conf = {
.write = ce4100_conf_write,
};

static int __init ce4100_pci_init(void)
int __init ce4100_pci_init(void)
{
init_sim_regs();
raw_pci_ops = &ce4100_pci_conf;
return 0;
/* Indicate caller that it should invoke pci_legacy_init() */
return 1;
}
subsys_initcall(ce4100_pci_init);
2 changes: 2 additions & 0 deletions arch/x86/platform/ce4100/ce4100.c
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
#include <linux/serial_reg.h>
#include <linux/serial_8250.h>

#include <asm/ce4100.h>
#include <asm/setup.h>
#include <asm/io.h>

Expand Down Expand Up @@ -129,4 +130,5 @@ void __init x86_ce4100_early_setup(void)
x86_init.resources.probe_roms = x86_init_noop;
x86_init.mpparse.get_smp_config = x86_init_uint_noop;
x86_init.mpparse.find_smp_config = sdv_find_smp_config;
x86_init.pci.init = ce4100_pci_init;
}
10 changes: 4 additions & 6 deletions arch/x86/xen/mmu.c
Original file line number Diff line number Diff line change
Expand Up @@ -986,10 +986,9 @@ static void xen_pgd_pin(struct mm_struct *mm)
*/
void xen_mm_pin_all(void)
{
unsigned long flags;
struct page *page;

spin_lock_irqsave(&pgd_lock, flags);
spin_lock(&pgd_lock);

list_for_each_entry(page, &pgd_list, lru) {
if (!PagePinned(page)) {
Expand All @@ -998,7 +997,7 @@ void xen_mm_pin_all(void)
}
}

spin_unlock_irqrestore(&pgd_lock, flags);
spin_unlock(&pgd_lock);
}

/*
Expand Down Expand Up @@ -1099,10 +1098,9 @@ static void xen_pgd_unpin(struct mm_struct *mm)
*/
void xen_mm_unpin_all(void)
{
unsigned long flags;
struct page *page;

spin_lock_irqsave(&pgd_lock, flags);
spin_lock(&pgd_lock);

list_for_each_entry(page, &pgd_list, lru) {
if (PageSavePinned(page)) {
Expand All @@ -1112,7 +1110,7 @@ void xen_mm_unpin_all(void)
}
}

spin_unlock_irqrestore(&pgd_lock, flags);
spin_unlock(&pgd_lock);
}

void xen_activate_mm(struct mm_struct *prev, struct mm_struct *next)
Expand Down

0 comments on commit 869c34f

Please sign in to comment.