Use of mikey179/vfsStream for Log tests breaks module builds #651
Comments
👍 that's the practical solution. |
|
👍 |
acoulton
added a commit
to kohana/unittest
that referenced
this issue
Dec 18, 2015
Per kohana/core@430a1d2 the vfsStream package is now required so that unit tests that interact with the filesystem (Log_File initially) can use a virtual in-memory filesystem for easier setup and test independence. Requiring this in kohana/unittest resolves kohana/core#651 by ensuring it's present for all module builds (which also run the kohana/core tests).
acoulton
added a commit
to kohana/unittest
that referenced
this issue
Dec 18, 2015
Require mikey179/vfsStream package for unit testing Fixes kohana/core#651
|
Fixed by kohana/unittest#60 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
#563 introduced a composer
require-devfor mikey179/vfsStream to allow virtual filesystem tests of the log writers.Unfortunately this breaks the builds for the other modules (eg https://travis-ci.org/kohana/image/jobs/97191751) because those builds include all the kohana/core tests (to check the module hasn't broken anything in core, I guess) but don't pick up the
require-devdependency from this package. Similarly, the kohana/kohana build is also going to fail for the same reason.I think the best solution is to
requiremikey179/vfsStream in kohana/unittest - the same way we handle phpunit, so it's always present in development environments for any module that has arequire-devon kohana/unittest.Alternatively we could modify the test suite to check if vfsStream is present and skip those tests if not.
Thoughts?
The text was updated successfully, but these errors were encountered: