Provide basic integration testing with Request and Response objects.

[arteymix]

This is a proposal for a skeleton TestCase that would be used to do integration testing with Kohana application.

I managed to test my application by self-requesting using internal Request just like the following:

$response = Request::factory('some/internal/endpoint')
    ->method(Request::POST)
    ->post('key', 'value')
    ->execute();

$this->assertEquals(200, $response->status(), $response->body());

But this gets a little messy and a lot of work has to be duplicated (especially for other status codes).

What I propose is a simple TestCase_Integration that would provide primitives for testing Response objects, making building and testing quality application simpler.

$this->assertOk($response);
$this->assertPermanentRedirect('http://some/location', $response);

I would like to have your insights on the matter!

[arteymix]

I squashed everything in a single commit and rename the TestCase to suit Database_TestCase naming.

[acoulton]

Won't this potentially dump an enormous HTML string into your PHPUnit output? Don't think I like that idea.

[acoulton]

Not sure what I think about this. I think some of the assertion names (eg assertOk) aren't very clear what they're actually asserting. I'd prefer a single assertHttpStatus(200, $response) when reading the tests, which would also reduce risk of name conflicts. You could use constants for the status codes to avoid having magic numbers dotted around the tests.

Obviously the redirect assertions are more useful, because they're verifying the full state of the redirection.

I think if we were going to distribute this, we'd need to unit test the assertions themselves, I'm not a fan of assertion methods that don't have coverage as it's hellish if an assertion doesn't actually test what you think it does.

I also don't know if it's a good idea to encourage people to do these sorts of tests in-process, because I don't think Kohana's global state is well-enough isolated to make the request execution independent. I'd generally want to test at this level over HTTP, either with Behat or for example by driving Browserkit or Mink through a PHPUnit test suite.

[acoulton]

I think this would be better as a first-class PHPUnit assertion, so that if it fails it can show the whole of the status/location header/etc in a useful failure message that describes the overall assertion and what was incorrect, rather than a chain of assertEquals.

For example, Expected 200 to equal 301 but it did not doesn't tell you whether the Location header was set or not, so you don't know if the issue is that the application never redirected, or it did but the status code went wrong along the way.