Remove email field from GitHub issue reports #FIXIT (53 minutes ahead…

… of schedule) Reviewers: alpert, kamens Reviewed By: kamens Differential Revision: http://phabricator.khanacademy.org/D412
kohlmeier · Jul 18, 2012 · 20e8703 · 20e8703
1 parent 915b69d
commit 20e8703
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/exercises/khan-exercise.html b/exercises/khan-exercise.html
@@ -84,7 +84,6 @@
                     </ul>
                 </fieldset>
                 <label for="issue-title">Issue Title:<input type="text" name="issue-title" id="issue-title" /></label>
-                <label for="issue-email">Your Email (optional):<input type="text" name="issue-email" id="issue-email" /></label>
                 <label for="issue-body">Description of Issue:<textarea name="issue-body" id="issue-body"></textarea></label>
                 <input type="submit" class="simple-button" value="Submit Issue">
                 <a href="/#" id="issue-cancel">Cancel</a>

diff --git a/khan-exercise.js b/khan-exercise.js
@@ -2174,7 +2174,7 @@ var Khan = (function() {
             e.preventDefault();
 
             $("#issue").hide(500);
-            $("#issue-title, #issue-email, #issue-body").val("");
+            $("#issue-title, #issue-body").val("");
 
         });
 
@@ -2189,7 +2189,6 @@ var Khan = (function() {
             var pretitle = exerciseName,
                 type = $("input[name=issue-type]:checked").prop("id"),
                 title = $("#issue-title").val(),
-                email = $("#issue-email").val(),
                 path = exerciseFile + "?seed=" +
                     problemSeed + "&problem=" + problemID,
                 pathlink = "[" + path + (exercise.data("name") != null && exercise.data("name") !== exerciseId ? " (" + exercise.data("name") + ")" : "") + "](http://sandcastle.khanacademy.org/media/castles/Khan:master/exercises/" + path + "&debug)",
@@ -2199,7 +2198,7 @@ var Khan = (function() {
                     ("loaded, " + (MathJax.isReady ? "" : "NOT ") + "ready, queue length: " + MathJax.Hub.queue.queue.length)),
                 sessionStorageInfo = (typeof sessionStorage === "undefined" || typeof sessionStorage.getItem === "undefined" ? "sessionStorage NOT enabled" : null),
                 warningInfo = $("#warning-bar-content").text(),
-                parts = [email ? "Reporter: " + email : null, $("#issue-body").val() || null, pathlink, historyLink, "    " + JSON.stringify(guessLog), agent, sessionStorageInfo, mathjaxInfo, warningInfo],
+                parts = [$("#issue-body").val() || null, pathlink, historyLink, "    " + JSON.stringify(guessLog), agent, sessionStorageInfo, mathjaxInfo, warningInfo],
                 body = $.grep(parts, function(e) { return e != null; }).join("\n\n");
 
             var mathjaxLoadFailures = $.map(MathJax.Ajax.loading, function(info, script) {