Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use jlong for HANDLE and GetProcessId instead of Nt kernel private fu… #53

Merged
merged 1 commit into from
Jul 14, 2018
Merged

Use jlong for HANDLE and GetProcessId instead of Nt kernel private fu… #53

merged 1 commit into from
Jul 14, 2018

Conversation

stephanreiter
Copy link

…nction

HANDLE is a typedef for a void*. On Win64 we cannot safely wrap that in a 32-bit int, so switch to 64-bit long. The hope is that this fixes random test failures that occur more when the system had been under load recently (and therefore has more open/recently closed handles).

@stephanreiter
Copy link
Author

@oleg-nenashev as a next step we can consider using long for PIDs. Unsigned int would suffice, though, as PIDs have DWORD (32-bit, unsigned) type on Windows.

@stephanreiter
Copy link
Author

@oleg-nenashev does this fix the flakiness-issue you experienced?

@oleg-nenashev
Copy link
Member

@stephanreiter sorry, I somehow missed this pull request. Looking

@oleg-nenashev oleg-nenashev merged commit a7da800 into jenkinsci:master Jul 14, 2018
@stephanreiter
Copy link
Author

@oleg-nenashev Thanks!! Do you have everything in place for an alpha release of the next WinP that we can base the following Jenkins PR on? jenkinsci/jenkins#3414
Would be awesome if you could support me in finishing that. :-)

@oleg-nenashev
Copy link
Member

oleg-nenashev commented Jul 17, 2018 via email

@stephanreiter
Copy link
Author

Cool! :) Thanks a lot, @oleg-nenashev

@stephanreiter stephanreiter deleted the long_handles branch July 17, 2018 12:56
@oleg-nenashev
Copy link
Member

@stephanreiter I have released all the patches in 1.27. Currently the release flow has some issues, because test executables are not properly built in the Maven Checkout directory. I will probably update pom.xml to always build the native binaries during the release. IIRC previously @kohsuke used to build on one machine and then release on another one, but now it's rather preferable to do everything on a single machine since the repository has more test automation now

I have worked around that, but now I wait till new GPG keys get synced. It may take a while

@oleg-nenashev
Copy link
Member

@stephanreiter this is finally out as 1.27. Last time I checked 6 days ago, GPG keys were still unsynced. But now the release went fine. Not sure why it took so long to sync...

@stephanreiter
Copy link
Author

@oleg-nenashev super! How can I use 1.27 from jenkins? I updated my pull request (jenkinsci/jenkins#3414), but the build failed because of a missing https://repo.azure.jenkins.io/public/org/jvnet/winp/winp/1.27/winp-1.27.jar

@oleg-nenashev
Copy link
Member

@stephanreiter apparently I didn't promote the repo in Maven Central properly, so it got stuck in staging. The release artifact is promoted now, I will retrigger your build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants