Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change boost::shared_ptr to std::shared_ptr #26

Merged
merged 1 commit into from Apr 17, 2021
Merged

Change boost::shared_ptr to std::shared_ptr #26

merged 1 commit into from Apr 17, 2021

Conversation

AchmadFathoni
Copy link
Contributor

@AchmadFathoni AchmadFathoni commented Apr 14, 2021 •
edited

Starting with PCL 1.11, PCL uses std::shared_ptr and std::weak_ptr instead of the boost smart pointers. The change leverages type aliases included with the 1.10.0 release

@AchmadFathoni AchmadFathoni mentioned this pull request Apr 14, 2021
Closed
@koide3
Copy link
Owner

koide3 commented Apr 16, 2021

Thanks for your PR. Maybe it's better to change them to pcl::shared_ptr to support the latest PCL as well as older ones.

@AchmadFathoni
Copy link
Contributor Author

Done, now it uses pcl::shared_ptr.

@koide3 koide3 merged commit 6887cf4 into koide3:master Apr 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AchmadFathoni @koide3