Skip to content
This repository has been archived by the owner on Oct 2, 2021. It is now read-only.

Implement base64 support in C++ #168

Closed
theoreticalbts opened this issue Mar 24, 2021 · 0 comments · Fixed by #171
Closed

Implement base64 support in C++ #168

theoreticalbts opened this issue Mar 24, 2021 · 0 comments · Fixed by #171
Labels
enhancement New feature or request showstopper

Comments

@theoreticalbts
Copy link
Contributor

theoreticalbts commented Mar 24, 2021

Currently we use b58, however due to O(n^2) nature of b58 coding, this isn't ideal for large strings.

Let's use base64 instead.

We can't change the default in C++ from base58 to base64 until Golang supports base64. So we should change the C++ and Golang defaults together as part of #169.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request showstopper
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants