This repository has been archived by the owner on Oct 2, 2021. It is now read-only.
Autogen thunk ids #205
Open
Autogen thunk ids #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing globbed in CMakeLists.txt
theoreticalbts
force-pushed
the
autogen-thunk-ids
branch
from
35c14bb
to
a308cee
Compare
|
Rebased to latest |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the manual transcription of system call / thunk ID's causes problems like this.
I've moved these to separate files in
types/, implemented a small script to autogenerate theenumfrom a list of names, and added it to CI. This should ensure ID's are always correctly generated and avoid the error-prone process of manual transcription of ID's.