Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove wait after onemkl dft calls #89

Merged
merged 5 commits into from
Mar 14, 2024
Merged

Remove wait after onemkl dft calls #89

merged 5 commits into from
Mar 14, 2024

Conversation

yasahi-hpc
Copy link
Collaborator

@yasahi-hpc yasahi-hpc commented Mar 13, 2024 •
edited
Loading

Resolves #82

In this PR, we have

  1. removed the .wait() after oneMKL calls to make KokkosFFT APIs asynchronous
  2. Kokkos::fence() exec.fence() added after KokkosFFT API calls (in examples)
  3. unit tests passed after modifications on Intel PVC

@yasahi-hpc yasahi-hpc self-assigned this Mar 13, 2024
@yasahi-hpc yasahi-hpc added bug Something isn't working enhancement New feature or request labels Mar 13, 2024
masterleinad
masterleinad reviewed Mar 13, 2024
View reviewed changes
examples/01_1DFFT/01_1DFFT.cpp Outdated Show resolved Hide resolved
examples/01_1DFFT/01_1DFFT.cpp Outdated Show resolved Hide resolved
fft/src/KokkosFFT_SYCL_transform.hpp Outdated Show resolved Hide resolved
@yasahi-hpc
Copy link
Collaborator Author

Hi @masterleinad

Thank you for your review. I made a fix based on your comments

@yasahi-hpc
Copy link
Collaborator Author

@masterleinad
Since most of the issues are fixed, I will merge this PR. Any comments or suggestions are still welcome. Thank you again for your help.

@yasahi-hpc yasahi-hpc merged commit e5be444 into main Mar 14, 2024
20 checks passed
@yasahi-hpc yasahi-hpc deleted the remove-wait-in-sycl branch March 14, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masterleinad masterleinad Awaiting requested review from masterleinad

Assignees

@yasahi-hpc yasahi-hpc

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Function with execution space should be asynchronous. SYCL backend performs a barrier inside
2 participants
@yasahi-hpc @masterleinad