Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build on i686 and armv7hl broken #2312

Closed
junghans opened this issue Sep 11, 2019 · 4 comments
Closed

Build on i686 and armv7hl broken #2312

junghans opened this issue Sep 11, 2019 · 4 comments

Comments

@junghans
Copy link
Contributor

From https://koji.fedoraproject.org/koji/taskinfo?taskID=37611340 (as dependency for RedHat LAMMPS package).

On i686:

BUILDSTDERR: In file included from /builddir/build/BUILD/kokkos-8bf914b2ec6eeea984740b4a4fae38b6cacc9ab2/core/src/Kokkos_HostSpace.hpp:52,
BUILDSTDERR:                  from /builddir/build/BUILD/kokkos-8bf914b2ec6eeea984740b4a4fae38b6cacc9ab2/core/src/Kokkos_Atomic.hpp:71,
BUILDSTDERR:                  from /builddir/build/BUILD/kokkos-8bf914b2ec6eeea984740b4a4fae38b6cacc9ab2/core/src/impl/Kokkos_Spinwait.cpp:47:
BUILDSTDERR: /builddir/build/BUILD/kokkos-8bf914b2ec6eeea984740b4a4fae38b6cacc9ab2/core/src/Kokkos_Core_fwd.hpp:60:30: error: static assertion failed: Kokkos assumes 64-bit build; i.e., 8-byte pointers
BUILDSTDERR:    60 | static_assert(sizeof(void *) == 8,
BUILDSTDERR:       |               ~~~~~~~~~~~~~~~^~~~
BUILDSTDERR: make[2]: *** [core/src/CMakeFiles/kokkoscore.dir/build.make:235: core/src/CMakeFiles/kokkoscore.dir/impl/Kokkos_Spinwait.cpp.o] Error 1
BUILDSTDERR: make[2]: *** Waiting for unfinished jobs....

Details here.

Same on armv7hl:

BUILDSTDERR: In file included from /builddir/build/BUILD/kokkos-8bf914b2ec6eeea984740b4a4fae38b6cacc9ab2/core/src/Kokkos_Core.hpp:50,
BUILDSTDERR:                  from /builddir/build/BUILD/kokkos-8bf914b2ec6eeea984740b4a4fae38b6cacc9ab2/core/src/impl/Kokkos_Core.cpp:44:
BUILDSTDERR: /builddir/build/BUILD/kokkos-8bf914b2ec6eeea984740b4a4fae38b6cacc9ab2/core/src/Kokkos_Core_fwd.hpp:60:30: error: static assertion failed: Kokkos assumes 64-bit build; i.e., 8-byte pointers
BUILDSTDERR:    60 | static_assert(sizeof(void *) == 8,
BUILDSTDERR:       |               ~~~~~~~~~~~~~~~^~~~
@mhoemmen
Copy link
Contributor

"Kokkos assumes 64-bit build; i.e., 8-byte pointers" -- I'm pretty sure that's still the case. Do you have a strong interest in support on 32-bit machines?

@stanmoore1
Copy link
Contributor

See #866.

@crtrott
Copy link
Member

crtrott commented Sep 11, 2019

We need a strong reason to make this work. This is not necessarily trivial.

@junghans
Copy link
Contributor Author

I don't really care much, we can just leave the LAMMPS package on RedHat with kokkos.

But there should be an error at CMake time when using 32-bit archs.

@junghans junghans mentioned this issue Sep 11, 2019
Merged
gentoo-bot pushed a commit to gentoo/gentoo that referenced this issue Jul 28, 2020
@junghans
dev-cpp/kokkos: mark x86 as unsupported
c0f181f 
Bug: kokkos/kokkos#2312
Closes: https://bugs.gentoo.org/734156
Package-Manager: Portage-2.3.103, Repoman-2.3.23
Signed-off-by: Christoph Junghans <junghans@gentoo.org>
@junghans junghans mentioned this issue Oct 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@dalg24 @junghans @mhoemmen @crtrott @stanmoore1