Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmake: error out on non 8-byte pointer systems #2314

Merged
merged 1 commit into from Sep 11, 2019
Merged

cmake: error out on non 8-byte pointer systems #2314

merged 1 commit into from Sep 11, 2019

Conversation

junghans
Copy link
Contributor

Related to #2312.

mhoemmen
mhoemmen approved these changes Sep 11, 2019
View reviewed changes
Copy link
Contributor

@mhoemmen mhoemmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me. That CMake variable is handy. It only depends on try_compile according to the CMake 3.15 documentation, so cross compilation shouldn't affect it.

@dalg24 dalg24 merged commit d93e239 into kokkos:develop Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhoemmen mhoemmen mhoemmen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@junghans @mhoemmen @dalg24