Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make clean in Out of Source Build/Tests Does Not Work Correctly #502

Closed
nmhamster opened this issue Oct 24, 2016 · 4 comments
Closed

make clean in Out of Source Build/Tests Does Not Work Correctly #502

nmhamster opened this issue Oct 24, 2016 · 4 comments
Assignees
Labels
Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos)
Milestone

Comments

@nmhamster
Copy link
Contributor

Running a make clean in out of source build directory appears to fail.

../generate_makefile.bash --with-openmp --with-serial --with-pthread --arch=Power8 --compiler=`which pgc++`

Then proceed with a build and then attempt to clean it:

make[2]: Leaving directory `/home/sdhammo/git/kokkos-github-repo/build-pgi-1690/algorithms/unit_tests'
make[1]: Leaving directory `/home/sdhammo/git/kokkos-github-repo/build-pgi-1690/algorithms/unit_tests'
make -C example/fixture clean
make[1]: Entering directory `/home/sdhammo/git/kokkos-github-repo/build-pgi-1690/example/fixture'
make -j -f /ascldap/users/sdhammo/git/kokkos-github-repo/example/fixture/Makefile KOKKOS_SRC_PATH=/ascldap/users/sdhammo/git/kokkos-github-repo CXX=/home/projects/pwr8-rhel73-lsf/pgi/2016/16.9.0/linuxpower/16.9/bin/pgc++ KOKKOS_DEVICES=,OpenMP,Serial,Pthread KOKKOS_ARCH=Power8 GTEST_PATH=/ascldap/users/sdhammo/git/kokkos-github-repo/tpls/gtest KOKKOS_PATH=/ascldap/users/sdhammo/git/kokkos-github-repo/build-pgi-1690/install clean
make[2]: Entering directory `/home/sdhammo/git/kokkos-github-repo/build-pgi-1690/example/fixture'
/ascldap/users/sdhammo/git/kokkos-github-repo/example/fixture/Makefile:20: /ascldap/users/sdhammo/git/kokkos-github-repo/build-pgi-1690/install/Makefile.kokkos: No such file or directory
@nmhamster nmhamster added the Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos) label Oct 24, 2016
@crtrott
Copy link
Member

crtrott commented Oct 24, 2016

Does this happen after a successful build?

@crtrott crtrott added this to the Fall 2016 milestone Oct 24, 2016
@crtrott crtrott self-assigned this Oct 24, 2016
@nmhamster
Copy link
Contributor Author

Well its a bit confusing to be honest because the libraries seemed to build OK. The example did not. But make clean needs to work regardless right?

@crtrott
Copy link
Member

crtrott commented Oct 24, 2016

Yeah, it does. I just added a fake target "kokkos-clean" to the installed Makefile.kokkos. I now fix the nonexistent install/Makefile.kokkos if you call make clean without previously calling make install.

crtrott added a commit that referenced this issue Oct 24, 2016
@crtrott
Copy link
Member

crtrott commented Oct 24, 2016

Should be fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos)
Projects
None yet
Development

No branches or pull requests

2 participants