Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate_makefile.bash: "make install" is broken #503

Closed
pkestene opened this issue Oct 24, 2016 · 3 comments
Closed

generate_makefile.bash: "make install" is broken #503

pkestene opened this issue Oct 24, 2016 · 3 comments
Assignees
Labels
Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos)
Milestone

Comments

@pkestene
Copy link
Contributor

There is an inconsistency with target "make install":

When defining target install, variable PREFIX appears twice.

Right now PREFIX value set by user on command line of generate_makefile.bash is not taken into account, overriden by the second occurence of PREFIX on make install target.

So "make install" installs kokkos in the build directory, instead of prefix passed through command line.

@crtrott
Copy link
Member

crtrott commented Oct 24, 2016

Args. I screwed that up when improving our testing so that examples are build against an installed Kokkos in order to a) test compiling against an installed kokkos and b) improve compile times.
I'll fix that again.

@crtrott
Copy link
Member

crtrott commented Oct 24, 2016

Ok I think I got it. Note the library target hat to be renamed to "kokkoslib" and the one which is used for testing is actually "kokkoslib-test" and "install-test". The kokkoslib and install target will use the user provided prefix, the test targets will not. Does that sound good?

@crtrott crtrott added the Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos) label Oct 24, 2016
@crtrott crtrott added this to the Fall 2016 milestone Oct 24, 2016
@crtrott crtrott self-assigned this Oct 24, 2016
crtrott added a commit that referenced this issue Oct 24, 2016
@crtrott
Copy link
Member

crtrott commented Oct 24, 2016

Should be fixed now.

@crtrott crtrott closed this as completed Oct 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos)
Projects
None yet
Development

No branches or pull requests

2 participants