Runtime option for tuning #3459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Retest this please |
dalg24
reviewed
Oct 8, 2020
++beers_i_owe_dalg24
Co-authored-by: Damien L-G <dalg24+github@gmail.com>
dalg24
reviewed
Oct 8, 2020
Co-authored-by: Damien L-G <dalg24+github@gmail.com>
…koff/kokkos into feature/tuning-runtime-option
dalg24
reviewed
Oct 9, 2020
crtrott
requested changes
Oct 14, 2020
crtrott
approved these changes
Nov 5, 2020
|
@dalg24, re history cleanup, comfortable just squash-merging? No other work depends on this |
masterleinad
pushed a commit
to masterleinad/kokkos
that referenced
this pull request
Nov 9, 2020
* Added "tune_internals" function * Only tune Kokkos internals if it was requested * Only declare internal features if internal tuning is enabled * Fixed logic error in pre_initialize. ++beers_i_owe_dalg24 * Better documentation message in help * Remove extra space Co-authored-by: Damien L-G <dalg24+github@gmail.com> * Update core/src/impl/Kokkos_Core.cpp Co-authored-by: Damien L-G <dalg24+github@gmail.com> * Changed tune_kokkos_internals -> tune_internals * Format * Added initialization test * Fixed logic as per @crtrott's comments Co-authored-by: Damien L-G <dalg24+github@gmail.com>
dalg24
added a commit
to dalg24/kokkos
that referenced
this pull request
Jun 3, 2021
Bug was introduced in kokkos#3459 One argument was unitialized causing an heap overflow caught by the adress sanitizer
dalg24
added a commit
to dalg24/kokkos
that referenced
this pull request
Jun 3, 2021
Bug was introduced in kokkos#3459. One argument was uninitialized which yielded an heap overflow caught by the adress sanitizer.
masterleinad
pushed a commit
to masterleinad/kokkos
that referenced
this pull request
Jun 9, 2021
Bug was introduced in kokkos#3459. One argument was uninitialized which yielded an heap overflow caught by the adress sanitizer.
masterleinad
pushed a commit
to masterleinad/kokkos
that referenced
this pull request
Jun 9, 2021
Bug was introduced in kokkos#3459. One argument was uninitialized which yielded an heap overflow caught by the adress sanitizer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #3454 .
The tuning functionality is highly experimental. Further, people could want to do tuning, but not want Kokkos to tune itself (or user policies). This PR separates the idea of "the Kokkos Tuning infrastructure exists" from "Kokkos tunes itself," the latter of which is a runtime option. I introduced it as a default-off option, though I'm flexible on that