Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup heap buffer overflow in cmd line args parsing unit tests #4069

Merged
merged 1 commit into from
Jun 4, 2021

Conversation

dalg24
Copy link
Member

@dalg24 dalg24 commented Jun 3, 2021

Bug was introduced in #3459.

One argument was uninitialized which yielded an heap overflow caught by
the adress sanitizer.

Bug was introduced in kokkos#3459.
One argument was uninitialized which yielded an heap overflow caught by
the adress sanitizer.
@dalg24
Copy link
Member Author

dalg24 commented Jun 3, 2021

(do_other ? 4 : 0) + (do_tune ? 1 : 0);

and
sprintf(args_kokkos[device_idx + (do_device ? 1 : 0)], "dummy4arg=1");

indicate the intention of intercalating an "other" argument after the "device" one.

@crtrott crtrott merged commit d7730f4 into kokkos:develop Jun 4, 2021
@dalg24 dalg24 deleted the fixup_bug_introduced_in_3459 branch June 4, 2021 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants