SYCL TeamPolicy nested parallel_reduce #3783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masterleinad
force-pushed
the
sycl_team_reduce
branch
2 times, most recently
from
8d9bc1c
to
0a27d7e
Compare
nliber
requested changes
Feb 9, 2021
nliber
approved these changes
Feb 9, 2021
masterleinad
force-pushed
the
sycl_team_reduce
branch
from
73828a5
to
030fc63
Compare
nliber
approved these changes
Feb 12, 2021
masterleinad
changed the title
|
This should work now. |
dalg24
reviewed
Feb 25, 2021
masterleinad
force-pushed
the
sycl_team_reduce
branch
from
ababc58
to
421957c
Compare
|
@dalg24 I addressed your comments. |
|
What is the plan for relaxing the requirement for the vector length to be 1? |
My current plan is to have all the functionality working for |
crtrott
requested changes
Mar 1, 2021
crtrott
reviewed
Mar 1, 2021
masterleinad
force-pushed
the
sycl_team_reduce
branch
from
7c093ce
to
12dde12
Compare
|
Retest this please. |
nliber
approved these changes
Mar 2, 2021
| @@ -493,6 +584,7 @@ KOKKOS_INLINE_FUNCTION void parallel_for( | |||
| const Impl::ThreadVectorRangeBoundariesStruct<iType, Impl::SYCLTeamMember>& | |||
| loop_boundaries, | |||
| const Closure& closure) { | |||
| // FIXME_SYC: adapt for vector_length!=1 | |||
There was a problem hiding this comment.
Should be FIXME_SYCL (so we don't miss it later).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on top of #3763, this pull request implements TeamPolicy parallel_reduce. Currently, vector_length=1 is assumed.