Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SYCL outer TeamPolicy parallel_reduce #3818

Merged
merged 13 commits into from
Mar 17, 2021
Merged

SYCL outer TeamPolicy parallel_reduce #3818

merged 13 commits into from
Mar 17, 2021

Conversation

masterleinad
Copy link
Contributor

Depends on #3783. With this and #3815 TeamPolicy should be feature-complete for SYCL (excluding vector_size>1).

@masterleinad
Copy link
Contributor Author

Retest this please.

@masterleinad masterleinad marked this pull request as ready for review March 3, 2021 19:11
@masterleinad masterleinad requested a review from nliber March 3, 2021 19:11
@masterleinad masterleinad added this to the Tentative 3.4 Release milestone Mar 9, 2021
nliber
nliber requested changes Mar 9, 2021
View reviewed changes
core/src/SYCL/Kokkos_SYCL_Team.hpp Outdated Show resolved Hide resolved
core/src/SYCL/Kokkos_SYCL_Team.hpp Show resolved Hide resolved
core/src/SYCL/Kokkos_SYCL_Team.hpp Show resolved Hide resolved
@masterleinad masterleinad requested a review from nliber March 9, 2021 20:16
dalg24
dalg24 previously requested changes Mar 10, 2021
View reviewed changes
core/unit_test/TestTeamReductionScan.hpp Show resolved Hide resolved
core/src/SYCL/Kokkos_SYCL_Parallel_Team.hpp Outdated Show resolved Hide resolved
@masterleinad masterleinad mentioned this pull request Mar 11, 2021
Merged
@masterleinad masterleinad added the Blocks Promotion Overview issue for release-blocking bugs label Mar 11, 2021
This was referenced Mar 16, 2021
Merged
Merged
crtrott
crtrott reviewed Mar 17, 2021
View reviewed changes
Copy link
Member

@crtrott crtrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there. Just one question on the queue capture.

core/src/SYCL/Kokkos_SYCL_Parallel_Team.hpp Outdated Show resolved Hide resolved
@dalg24 dalg24 dismissed their stale review March 17, 2021 19:18

Comments have been addressed

@dalg24 dalg24 merged commit 018721f into kokkos:develop Mar 17, 2021
@masterleinad masterleinad deleted the sycl_outer_team_reduce branch March 17, 2021 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nliber nliber nliber approved these changes

@crtrott crtrott crtrott approved these changes

@dalg24 dalg24 Awaiting requested review from dalg24

Assignees
No one assigned
Labels
Blocks Promotion Overview issue for release-blocking bugs
Projects
None yet
Milestone
Tentative 3.4 Release
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@masterleinad @dalg24 @nliber @crtrott