Remove superfluous FunctorFinal specialization #3788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You are brave touching that, but I guess they weren't superfluous. |
masterleinad
force-pushed
the
remove_functor_final_specialization
branch
from
1a61190
to
4ea5595
Compare
|
This should be fine now. @Char-Aznable can you confirm that this works for you? |
masterleinad
force-pushed
the
remove_functor_final_specialization
branch
from
4ea5595
to
fd9b36f
Compare
|
@masterleinad This works for the example I posted in #3651 as of fd9b36f. Thanks for the patch! |
crtrott
approved these changes
Feb 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3651. We already handle all cases (scalar/array, Tag/void) above.