OpenMPTarget: Block unit tests that do not pass with the nvidia compiler. #3839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
February 22, 2021 19:55
…ckend with the nvidia compiler.
…enMPTarget backend tests that fail with nvidia compiler in the clang compiler.
…mented for the OpenMPTarget backend.
rgayatri23
changed the title
dalg24
previously requested changes
Mar 10, 2021
masterleinad
requested changes
Mar 10, 2021
core/CMakeLists.txt
Outdated
| @@ -7,7 +7,11 @@ IF (NOT Kokkos_INSTALL_TESTING) | |||
| ENDIF() | |||
|
|
|||
| KOKKOS_ADD_TEST_DIRECTORIES(unit_test) | |||
|
|
|||
| # FIXME_OPENMPTARGET - the nvidia compiler in the OpenMPTarget backend does not pass the perf_tests. | |||
There was a problem hiding this comment.
Suggested change
| # FIXME_OPENMPTARGET - the nvidia compiler in the OpenMPTarget backend does not pass the perf_tests. | |
| # FIXME_OPENMPTARGET - the PGI compiler in the OpenMPTarget backend does not pass the perf_tests. |
There was a problem hiding this comment.
Then let's rename everything to NVHPC.
added 5 commits
March 10, 2021 12:14
…tests that do not pass with the nvidia compiler.
…ar the confusion about the PGI/NVHPC compiler.
|
Retest this please. |
crtrott
approved these changes
Mar 17, 2021
core/unit_test/CMakeLists.txt
Outdated
| endif() | ||
|
|
||
| # FIXME_OPENMPTARGET - Comment non-passing tests with the NVIDIA HPC compiler nvc++ | ||
| if(KOKKOS_ENABLE_OPENMPTARGET AND KOKKOS_CXX_COMPILER_ID STREQUAL "PGI") |
There was a problem hiding this comment.
Suggested change
| if(KOKKOS_ENABLE_OPENMPTARGET AND KOKKOS_CXX_COMPILER_ID STREQUAL "PGI") | |
| if(KOKKOS_ENABLE_OPENMPTARGET AND | |
| (KOKKOS_CXX_COMPILER_ID STREQUAL PGI OR KOKKOS_CXX_COMPILER_ID STREQUAL NVHPC)) |
for CMake 3.20 (https://cmake.org/cmake/help/v3.20/variable/CMAKE_LANG_COMPILER_ID.html#variable:CMAKE__COMPILER_ID).
Co-authored-by: Daniel Arndt <arndtd@ornl.gov>
dalg24
reviewed
Mar 30, 2021
Comment on lines
+12
to
+16
| IF(KOKKOS_ENABLE_OPENMPTARGET | ||
| AND NOT KOKKOS_CXX_COMPILER_ID STREQUAL PGI | ||
| AND NOT KOKKOS_CXX_COMPILER_ID STREQUAL NVHPC) | ||
| KOKKOS_ADD_TEST_DIRECTORIES(perf_test) | ||
| ENDIF() |
dalg24
added a commit
to dalg24/kokkos
that referenced
this pull request
Mar 30, 2021
These had been inadvertently disbaled in kokkos#3839 Co-Authored-By: Nick Curtis <nicholas.curtis@amd.com> Co-Authored-By: Bruno Turcksin <bruno.turcksin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR blocks unit tests that do not pass with the nvidia-compiler based on the compiler-id.