Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup re-enable core performance tests #3903

Merged
merged 2 commits into from
Mar 31, 2021

Conversation

dalg24
Copy link
Member

@dalg24 dalg24 commented Mar 30, 2021

These had been inadvertently disbaled in #3839

Reported by @arghdos

These had been inadvertently disbaled in kokkos#3839

Co-Authored-By: Nick Curtis <nicholas.curtis@amd.com>
Co-Authored-By: Bruno Turcksin <bruno.turcksin@gmail.com>
Copy link
Contributor

@masterleinad masterleinad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@rgayatri23
Copy link
Contributor

LGTM. Sorry din't realize this in the earlier PR.
Also can we add the following change in this PR in core/unit_test/CMakeLists.txt

-    ${CMAKE_CURRENT_SOURCE_DIR}/openmptarget/TestOpenMPTarget_RangePolicy.cpp                                                                                                            
+    ${CMAKE_CURRENT_BINARY_DIR}/openmptarget/TestOpenMPTarget_RangePolicy.cpp 

Else it fails at linking stage on some machines.

@dalg24
Copy link
Member Author

dalg24 commented Mar 30, 2021

LGTM. Sorry din't realize this in the earlier PR.
Also can we add the following change in this PR in core/unit_test/CMakeLists.txt

-    ${CMAKE_CURRENT_SOURCE_DIR}/openmptarget/TestOpenMPTarget_RangePolicy.cpp                                                                                                            
+    ${CMAKE_CURRENT_BINARY_DIR}/openmptarget/TestOpenMPTarget_RangePolicy.cpp 

Else it fails at linking stage on some machines.

See 1a53a43

@dalg24 dalg24 merged commit e31f52e into kokkos:develop Mar 31, 2021
@dalg24 dalg24 deleted the fixup_reenable_core_performance_tests branch May 24, 2021 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants