Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cmake warning with pthread #3854

Merged
merged 1 commit into from
Mar 17, 2021
Merged

Conversation

dalg24
Copy link
Member

@dalg24 dalg24 commented Mar 16, 2021

-- Architectures:
CMake Warning (dev) at /Applications/CMake.app/Contents/share/cmake-3.19/Modules/FindPackageHandleStandardArgs.cmake:426 (message):
  The package name passed to `find_package_handle_standard_args` (PTHREAD)
  does not match the name of the calling package (TPLPTHREAD).  This can lead
  to problems in calling code that expects `find_package` result variables
  (e.g., `_FOUND`) to follow a certain pattern.
Call Stack (most recent call first):
  cmake/Modules/FindTPLPTHREAD.cmake:13 (FIND_PACKAGE_HANDLE_STANDARD_ARGS)
  cmake/kokkos_functions.cmake:235 (FIND_PACKAGE)
  cmake/kokkos_tpls.cmake:72 (KOKKOS_IMPORT_TPL)
  cmake/kokkos_tribits.cmake:236 (INCLUDE)
  CMakeLists.txt:170 (KOKKOS_SETUP_BUILD_ENVIRONMENT)
This warning is for project developers.  Use -Wno-dev to suppress it.

@dalg24 dalg24 requested review from jjwilke and jrmadsen March 16, 2021 23:15
Copy link
Contributor

@masterleinad masterleinad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK. We never use PTHREAD_FOUND.

@crtrott crtrott merged commit 985510c into kokkos:develop Mar 17, 2021
@dalg24 dalg24 deleted the cmake_warning_pthread branch March 17, 2021 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants