Deprecate backward compatibility features #3978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please rebase |
masterleinad
force-pushed
the
mark_backward_compatibilities_as_deprecated
branch
from
8259955
to
4006af9
Compare
|
Rebased. |
This was referenced May 6, 2021
dalg24
requested changes
May 6, 2021
example/tutorial/06_simple_mdrangepolicy/simple_mdrangepolicy.cpp
Outdated
Show resolved
Hide resolved
| @@ -56,7 +56,7 @@ | |||
| #include <Kokkos_OpenMPTargetSpace.hpp> | |||
| #include <Kokkos_ScratchSpace.hpp> | |||
| #include <Kokkos_Parallel.hpp> | |||
| #include <Kokkos_TaskPolicy.hpp> | |||
| #include <Kokkos_TaskScheduler.hpp> | |||
There was a problem hiding this comment.
Yes, that file just forwards to Kokkos_TaskScheduler.hpp:
kokkos/core/src/Kokkos_TaskPolicy.hpp
Lines 45 to 47 in 3efc176
I didn't want to deal with issuing a deprecation warning when using this file but I also don't see a reason to use a deprecated file.
There was a problem hiding this comment.
Yeah we probably should try and emit a warning if people include it.
Done. |
masterleinad
force-pushed
the
mark_backward_compatibilities_as_deprecated
branch
from
704271b
to
9a7e037
Compare
|
Retest this please. |
|
Retest this please |
|
Retest this please. |
1 similar comment
|
Retest this please. |
dalg24
approved these changes
May 20, 2021
ndellingwood
added a commit
to trilinos/Trilinos
that referenced
this pull request
Mar 2, 2022
Deprecated code updates corresponding to kokkos/kokkos#3978
Closed
ndellingwood
added a commit
to trilinos/Trilinos
that referenced
this pull request
Mar 2, 2022
Deprecated code updates corresponding to kokkos/kokkos#3978
ndellingwood
added a commit
to trilinos/Trilinos
that referenced
this pull request
Apr 7, 2022
Deprecated code updates corresponding to kokkos/kokkos#3978
ndellingwood
added a commit
to trilinos/Trilinos
that referenced
this pull request
Apr 18, 2022
Deprecated code updates corresponding to kokkos/kokkos#3978
ndellingwood
added a commit
to trilinos/Trilinos
that referenced
this pull request
Apr 20, 2022
Deprecated code updates corresponding to kokkos/kokkos#3978
tcclevenger
pushed a commit
to trilinos/Trilinos
that referenced
this pull request
May 26, 2022
Deprecated code updates corresponding to kokkos/kokkos#3978
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the spirit of #3973. I decided not to touch
ViewAllocateWithoutInitializingsince we already have some kind of deprecation commented but not enabled.Deprecated:
Kokkos::Experimental::Iterate->Kokkos::IterateKokkos::Experimental::MDRangePolicy->Kokkos::MDRangePolicyKokkos::Experimental::Iterate->Kokkos::IterateKokkos::Experimental::Rank->Kokkos::RankKokkos::Impl::is_array_layout->Kokkos::is_array_layoutKokkos::Impl::is_execution_policy->Kokkos::is_execution_policyKokkos::Impl::is_execution_space->Kokkos::is_execution_spaceKokkos::Impl::is_memory_space->Kokkos::is_memory_spaceKokkos::Impl::is_memory_traits->Kokkos::is_memory_traitsKokkos::Impl::is_space->Kokkos::is_spaceKokkos::Impl::SpaceAccessibility->Kokkos::SpaceAccessibility