Deprecate Kokkos_TaskPolicy.hpp #4011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalg24
reviewed
May 7, 2021
core/src/Kokkos_Macros.hpp
Outdated
Comment on lines
534
to
535
| #define KOKKOS_STRINGIZE_HELPER(x) #x | ||
| #define KOKKOS_STRINGIZE(x) KOKKOS_STRINGIZE_HELPER(x) |
There was a problem hiding this comment.
kokkos/core/src/impl/Kokkos_Error.hpp
Lines 221 to 222 in 2265de3
dalg24
reviewed
May 7, 2021
core/src/Kokkos_Macros.hpp
Outdated
| __FILE__ "(" KOKKOS_IMPL_TOSTRING(__LINE__) ") : warning: " #desc)) | ||
| #else | ||
| #define KOKKOS_DO_PRAGMA(x) _Pragma(#x) | ||
| #define KOKKOS_WARNING(desc) KOKKOS_DO_PRAGMA(message(#desc)) |
There was a problem hiding this comment.
Would you remind me why this is it not just #warning <msg>?
There was a problem hiding this comment.
That's what we are using in deal.II. Just #warning wasn't portable enough to also work with MSVC so we needed some kind of preprocessor macro and that's why we came up with this partly taken from http://goodliffe.blogspot.com/2009/07/c-how-to-say-warning-to-visual-studio-c.html. gcc and clang also don't like the MSVC version. I'm happy to replace it if there are better suggestions.
Rombur
approved these changes
May 12, 2021
crtrott
requested changes
May 24, 2021
dalg24
approved these changes
May 25, 2021
|
Retest this please. |
crtrott
approved these changes
May 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #3978 (comment) we wanted to deprecate this header. Since it requires defining some more preprocessor macros (differing between architectures) I decided to split this up into its own pull request.