Deprecate Experimental::MasterLock
#4094
Conversation
The class template is only specialized for the OpenMP backend. No one seems to know anything about it. It is apparently not used anywhere.
dalg24
force-pushed
the
remove_experimental_master_lock
branch
from
fdb38dd
to
4f8cbf5
Compare
| @@ -53,7 +53,9 @@ | |||
| #include <impl/Kokkos_Error.hpp> | |||
| #include <impl/Kokkos_Utilities.hpp> | |||
|
|
|||
| #ifdef KOKKOS_ENABLE_DEPRECATED_CODE_3 | |||
There was a problem hiding this comment.
So far, we have used KOKKOS_ENABLE_DEPRECATED_CODE to print deprecations warnings, not to remove deprecated code completely (except for KOKKOS_CONSTEXPR_14 constexpr in #4063).
I would want to take this opportunity to discuss/clarify what the macro is supposed to do.
There was a problem hiding this comment.
Deprecation warnings did not work. See #3217 (comment)
There was a problem hiding this comment.
Hmmm... I just tried to reproduce in https://godbolt.org/z/xq86aMajc and the deprecations seem to work fine for gcc, clang, icc and msvc. Would you mind reminding me what the specific issue is?
There was a problem hiding this comment.
There was a problem hiding this comment.
It seems to work if you specify the C++ version flag correctly, though: https://godbolt.org/z/KP14aaneW
There was a problem hiding this comment.
generally KOKKOS_ENABLE_DEPRECATED_CODE should be used to remove deprecated code (if it is not defined the code is removed). Hence the name. We probably should have another option for removing warnings if required: KOKKOS_ENABLE_DEPRECATION_WARNINGS.
There was a problem hiding this comment.
OK. In that case, I'm fine with this pull request. I'm happy to rework the current behavior of the flags in a follow-up pull request.
There was a problem hiding this comment.
BTW if you mark the forward declaration as deprecated you will get the warnings in your specialization with GCC (regardless of the version). I missed you had omitted it.
There was a problem hiding this comment.
...but other compilers need the specialization to be deprecated: https://godbolt.org/z/WPz9TzMPc
There was a problem hiding this comment.
(Re-open #3217)
The class template is only specialized for the OpenMP backend.
No one seems to know anything about it.
It is apparently not used anywhere.