Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Kokkos_ENABLE_DEPRECATION_WARNINGS and remove deprecated code with Kokkos_ENABLE_DEPRECATED_CODE_3 #4106

Merged

Conversation

masterleinad
Copy link
Contributor

Based on top of #4094.

In response to https://github.com/kokkos/kokkos/pull/4094/files#r654516851:

generally KOKKOS_ENABLE_DEPRECATED_CODE should be used to remove deprecated code (if it is not defined the code is removed). Hence the name. We probably should have another option for removing warnings if required: KOKKOS_ENABLE_DEPRECATION_WARNINGS.

@masterleinad masterleinad force-pushed the introdcue_enable_deprecation_warnings branch 2 times, most recently from d1eecb3 to e217181 Compare June 18, 2021 18:26
@masterleinad masterleinad force-pushed the introdcue_enable_deprecation_warnings branch from e217181 to 137a6ce Compare June 18, 2021 18:59
@masterleinad masterleinad marked this pull request as ready for review June 18, 2021 18:59
core/src/Cuda/Kokkos_CudaSpace.cpp Show resolved Hide resolved
cmake/kokkos_enable_options.cmake Outdated Show resolved Hide resolved
Co-authored-by: Damien L-G <dalg24+github@gmail.com>
@crtrott crtrott merged commit 408700c into kokkos:develop Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants