hpcbind: Use double quotes around $@ when invoking user command #4284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the end of the hpcbind script, when running the user command, the command arguments are in the $@ variable. Unless $@ is enclosed by double quotes, those arguments are subject to word splitting in bash, which creates problems when those arguments have spaces that should be preserved. An example that would fail without this commit is `hpcbind -- foo args="hello world"`.
|
Can one of the admins verify this patch? |
|
This fix is incomplete in that |
mpokorny
added a commit
to mpokorny/kokkos
that referenced
this pull request
Dec 21, 2021
As mentioned by @opensdh in kokkos#4284 (comment), the use of eval "$@" (in case hwloc-bind is not used) is counter-productive. Modulo any backward compatibility concern (which I don't see, myself), this PR addresses those concerns raised by @opensdh.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the end of the hpcbind script, when running the user command, the$@ variable. Unless $ @ is enclosed by
command arguments are in the
double quotes, those arguments are subject to word splitting in bash,
which creates problems when those arguments have spaces that should be
preserved. An example that would fail without this commit is
hpcbind -- foo args="hello world".