remove eval of command args in hpcbind
#4630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
I assume you only meant to have b31bbab on top of |
mpokorny
force-pushed
the
quote-hpcbind
branch
from
b31bbab
to
0572ffe
Compare
As mentioned by @opensdh in kokkos#4284 (comment), the use of eval "$@" (in case hwloc-bind is not used) is counter-productive. Modulo any backward compatibility concern (which I don't see, myself), this PR addresses those concerns raised by @opensdh.
|
Rebased the branch onto develop |
crtrott
approved these changes
Dec 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned by @opensdh in #4284 (comment), the use of
eval "$@"(in casehwloc-bindis not used) is counter-productive. Modulo any backward compatibility concern (which I don't see, myself), this PR addresses those concerns raised by @opensdh.