change windows.h include to lowercase to improve mingw compatibility #4564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
dalg24
requested changes
Nov 30, 2021
|
@dalg24 Would you be able to help with the rebase? I don't know how to do that without it wanting to review many merge conflicts. Alternatively, I can close this an re-submit on a new branch. |
I will take care of it and push to your branch |
dalg24
force-pushed
the
cg/lowercase-windows-include
branch
from
a04e807
to
70772a2
Compare
dalg24
approved these changes
Nov 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes a single instance of
Windows.hto it's lowercase form. All other instances ofwindows.hincludes are already lowercase with the exception of this one.When building on Windows, a case-insensitive file-system is usually employed, but when cross-compiling on a Linux host for a Windows target case-senstive file-systems are more common. MinGW consistently uses lowercase names for all libraries and header files.