-
Notifications
You must be signed in to change notification settings - Fork 539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Kokkos #3740
add Kokkos #3740
Conversation
300b388
to
e72eb7b
Compare
As far as I understand,
This seems to be defined as a MSVC intrinsic, but is missing from Googling around, it looks like ReactOS carries gcc ports around? I tried adding both |
I'm a bit confused: what was that made the MinGW build work? |
I don't know exactly, there were a lot of changes and files modified between the 3.4.1 release and 3.5.0. I am just guessing some macro flags or something was mis-aligned or not triggering? I don't know if my ramblings above were actually meaningful in any way, so take them with a grain of salt |
Ok, I missed you had upgraded the version in the meantime, that may have had an effect then. |
I also attempted to submit a patch upstream here for completeness. |
* initial commit adding Kokkos * add filter to remove 32 bit platforms * add branch to disable openmp on apple * generalize disable-stacktrace patch to both musl and mingw * update version to 3.5.0 release * refresh stacktrace patch and remove from mingw conditional * Apply suggestions from code review Co-authored-by: Mosè Giordano <giordano@users.noreply.github.com>
This PR adds a
build_tarballs.jl
for the Kokkos library.This build is close to default build options, only added openMP support.Tested locally on
x86_64-linux-*
,powerpc
, andfreebsd
.mingw
still has some issues I am working through