-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not append stacktrace to the message when throwing a std::runtime_error
#4671
Conversation
@ibaned please confirm that this was an oversight |
The last 3 commits are optional |
@dalg24 correct, I don't remember a specific reason why this was changed. |
f508325
to
a3ad04f
Compare
I decided to revert after discussing with Cezary since it was adding a dependency on GMock. We can revisit later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Retest this please |
56cbe14
to
f9b2ed0
Compare
std::runtime_error
Solution proposed changed since the approval
@ibaned @cz4rs I dismissed your reviews since I decided to propose a different resolution after discussing the changes on the developer Slack channel. #4672 appends the current call stack to the error message when calling |
We used to include the call stack in the error message when throwing a runtime exception but it looks like we accidentally unconditionally disabled the functionality in the refactor #2226
EDIT decided to strip the stacktrace from the error message since it can be obtained on the user side when handling the error