Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print current call stack when calling Kokkos::abort() from the host #4672

Merged
merged 3 commits into from
Jan 13, 2022

Conversation

dalg24
Copy link
Member

@dalg24 dalg24 commented Jan 13, 2022

Improve error message to help locate the problem without a debugger

Related to #4671
IMO, it is arguable whether we should append the backtrace to the message give to std::runtime_error, but when calling abort we absolutely should do it.

@dalg24 dalg24 force-pushed the host_abort_print_call_stack branch 2 times, most recently from 2c19b1c to f0df31a Compare January 13, 2022 15:27
@crtrott crtrott merged commit a746fe9 into kokkos:develop Jan 13, 2022
@dalg24 dalg24 deleted the host_abort_print_call_stack branch January 13, 2022 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants