Implement desired fence behavior for view initialization #4823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masterleinad
force-pushed
the
check_initialization_view_constructor
branch
from
2045769
to
3b9bddf
Compare
PhilMiller
reviewed
Mar 1, 2022
|
Where is the updated documentation in the wiki? I don't see any mention of 'fence' in the View API ref |
|
The only mention of 'fence' I see in the programming guide View page is regarding deallocation of view-of-views |
PhilMiller
reviewed
Mar 2, 2022
https://github.com/kokkos/ProgrammingGuide/wiki/Kokkos%3A%3AView |
|
Code looks good. I'll want to review the updated documentation (waiting for repo access), and then I'm happy to approve. |
|
Retest this please. |
|
Please pull in the expanded testing that got added in #4826. |
PhilMiller
approved these changes
Mar 3, 2022
crtrott
approved these changes
Mar 23, 2022
dalg24
reviewed
Mar 23, 2022
ndellingwood
added a commit
to trilinos/Trilinos
that referenced
this pull request
Apr 26, 2022
See changes in kokkos/kokkos#4823 and issue kokkos/kokkos#4902
ndellingwood
added a commit
to trilinos/Trilinos
that referenced
this pull request
Apr 26, 2022
See changes in kokkos/kokkos#4823 and issue kokkos/kokkos#4902
ndellingwood
added a commit
to trilinos/Trilinos
that referenced
this pull request
May 6, 2022
See changes in kokkos/kokkos#4823 and issue kokkos/kokkos#4902
ndellingwood
added a commit
to trilinos/Trilinos
that referenced
this pull request
May 6, 2022
See changes in kokkos/kokkos#4823 and issue kokkos/kokkos#4902
ndellingwood
added a commit
to trilinos/Trilinos
that referenced
this pull request
May 10, 2022
See changes in kokkos/kokkos#4823 and issue kokkos/kokkos#4902
ndellingwood
added a commit
to trilinos/Trilinos
that referenced
this pull request
May 19, 2022
See changes in kokkos/kokkos#4823 and issue kokkos/kokkos#4902
ndellingwood
added a commit
to trilinos/Trilinos
that referenced
this pull request
May 19, 2022
See changes in kokkos/kokkos#4823 and issue kokkos/kokkos#4902
ndellingwood
added a commit
to trilinos/Trilinos
that referenced
this pull request
May 31, 2022
See changes in kokkos/kokkos#4823 and issue kokkos/kokkos#4902
ndellingwood
added a commit
to trilinos/Trilinos
that referenced
this pull request
May 31, 2022
See changes in kokkos/kokkos#4823 and issue kokkos/kokkos#4902
ndellingwood
added a commit
to trilinos/Trilinos
that referenced
this pull request
Jun 22, 2022
See changes in kokkos/kokkos#4823 and issue kokkos/kokkos#4902
ndellingwood
added a commit
to trilinos/Trilinos
that referenced
this pull request
Jun 22, 2022
See changes in kokkos/kokkos#4823 and issue kokkos/kokkos#4902
ndellingwood
added a commit
to trilinos/Trilinos
that referenced
this pull request
Aug 5, 2022
See changes in kokkos/kokkos#4823 and issue kokkos/kokkos#4902
ndellingwood
added a commit
to trilinos/Trilinos
that referenced
this pull request
Aug 5, 2022
See changes in kokkos/kokkos#4823 and issue kokkos/kokkos#4902
ndellingwood
added a commit
to trilinos/Trilinos
that referenced
this pull request
Aug 12, 2022
See changes in kokkos/kokkos#4823 and issue kokkos/kokkos#4902
ndellingwood
added a commit
to trilinos/Trilinos
that referenced
this pull request
Aug 12, 2022
See changes in kokkos/kokkos#4823 and issue kokkos/kokkos#4902
ndellingwood
added a commit
to trilinos/Trilinos
that referenced
this pull request
Aug 30, 2022
See changes in kokkos/kokkos#4823 and issue kokkos/kokkos#4902
ndellingwood
added a commit
to trilinos/Trilinos
that referenced
this pull request
Aug 30, 2022
See changes in kokkos/kokkos#4823 and issue kokkos/kokkos#4902
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4697 (I already documented the behavior in the Wiki).
Note that
ZeroMemsetbranch currently doesn't call any Kokkosfencealready no matter if we are providing an execution space or not. TheKokkos::Viewinitialization already only fenced the given (or default) execution space and this pull request only removes the fence if an execution space is explicitly specified.