Allow Kokkos::resize to take an execution space #4844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masterleinad
added
the
Question
masterleinad
force-pushed
the
resize_execution_space
branch
from
23e2621
to
96fc533
Compare
|
Retest this please. |
masterleinad
force-pushed
the
resize_execution_space
branch
from
4b02500
to
776ab5e
Compare
masterleinad
force-pushed
the
resize_execution_space
branch
from
776ab5e
to
b2f11e4
Compare
ldh4
reviewed
Jun 22, 2022
masterleinad
force-pushed
the
resize_execution_space
branch
from
f055b8c
to
98b7b67
Compare
ldh4
approved these changes
Jun 22, 2022
crtrott
requested changes
Jun 29, 2022
containers/src/Kokkos_DualView.hpp
Outdated
| static_assert( | ||
| !alloc_prop_input::allow_padding, | ||
| "The view constructor arguments passed to Kokkos::resize must " | ||
| "not explicitly allow padding!"); |
There was a problem hiding this comment.
In the discussion around #5035 (comment) we said that we shouldn't be allowed to explicitly request padding but I'm happy to change if that's what we want.
|
Seems to work with |
crtrott
approved these changes
Jun 30, 2022
|
Retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #4792, #4823, and #4826. Specifying an execution space, we could at least get rid of a global fence (and possibly some instance fences depending on #4823 and #4826).
If the View's count is 1, we of course still deallocate data which implies a global fence.
So far tests are missing andthis is mostly intended to discuss if we want to provide these overloads.