Cleanup/rework fence overloads

[dalg24]

(Re-opening #5147 that I accidentally closed)

Yet another attempt to harmonize/simplify the interface of execution spaces.
These changes are necessary to write generic code in #5144

• Prefer default argument in ExecutionSpace::fence and "global" fence
• Remove ExecutionSpace::impl_static_fence(void)
• Provide (missing) HPX::impl_static_fence
• Drop leading execution space argument in OpenMP::impl_static_fence
• Remove ExecSpaceInitializerBase::fence() overload that takes no label argument

[masterleinad]

Looks good to me. Maybe, we should add some tests checking for expected labels for unnamed and static fences given some of the changes in this pull request.

[dalg24]

Looks good to me. Maybe, we should add some tests checking for expected labels for unnamed and static fences given some of the changes in this pull request.

What else than

kokkos/core/unit_test/tools/TestEventCorrectness.hpp

Lines 142 to 213 in a793105

	/**
	* Test that fencing an instance with a name yields a fence
	* event of that name, and the correct device ID
	*/
	TEST(kokkosp, test_named_instance_fence) {
	test_wrapper([&]() {
	auto root = Kokkos::Tools::Experimental::device_id_root<
	Kokkos::DefaultExecutionSpace>();
	std::vector<FencePayload> expected{
	{"named_instance", FencePayload::distinguishable_devices::no,
	root + num_instances}};
	expect_fence_events(expected, [=]() {
	Kokkos::DefaultExecutionSpace ex;
	ex.fence("named_instance");
	});
	num_instances += increment<Kokkos::DefaultExecutionSpace>::size;
	});
	}
	/**
	* Test that fencing an instance without a name yields a fence
	* event of a correct name, and the correct device ID
	*/
	TEST(kokkosp, test_unnamed_instance_fence) {
	test_wrapper([&]() {
	auto root = Kokkos::Tools::Experimental::device_id_root<
	Kokkos::DefaultExecutionSpace>();
	std::vector<FencePayload> expected{
	{"Unnamed Instance Fence", FencePayload::distinguishable_devices::no,
	root + num_instances}};
	expect_fence_events(expected, [=]() {
	Kokkos::DefaultExecutionSpace ex;
	ex.fence();
	});
	num_instances += increment<Kokkos::DefaultExecutionSpace>::size;
	});
	}
	/**
	* Test that invoking a global fence with a name yields a fence
	* event of a correct name, and fences the root of the default device
	*/
	TEST(kokkosp, test_named_global_fence) {
	test_wrapper([&]() {
	auto root = Kokkos::Tools::Experimental::device_id_root<
	Kokkos::DefaultExecutionSpace>();
	std::vector<FencePayload> expected{
	{"test global fence", FencePayload::distinguishable_devices::no, root}};
	expect_fence_events(expected,
	[=]() { Kokkos::fence("test global fence"); });
	});
	}
	/**
	* Test that invoking a global fence with no name yields a fence
	* event of a correct name, and fences the root of the default device
	*/
	TEST(kokkosp, test_unnamed_global_fence) {
	test_wrapper([&]() {
	auto root = Kokkos::Tools::Experimental::device_id_root<
	Kokkos::DefaultExecutionSpace>();
	std::vector<FencePayload> expected{
	{"Unnamed Global Fence", FencePayload::distinguishable_devices::no,
	root}};
	expect_fence_events(expected, [=]() { Kokkos::fence(); });
	num_instances += increment<Kokkos::DefaultExecutionSpace>::size;
	});

would you like to see?

[dalg24]

Ignoring OpenMPTarget hang that will likely timeout